Gateway: reconcile streamed output to final payload#3
Open
brian-chenyang wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Problem This Solves
OpenResponses currently streams assistant text from tool-call turns into
response.output_text.delta. If the final answer is a plain paragraph, OpenMAI can persist and display tool narration such as “Let me check the skill” before the actual answer.This change reconciles the stream with the authoritative final agent payload before terminal completion, so consumers receive a canonical replacement instead of persisting mixed tool narration.
Changes
response.output_text.replacedwhen streamed assistant text differs from the authoritative final payloadresponse.completedEvidence
pnpm tsgopnpm buildpnpm exec vitest run src/gateway/openresponses-http.test.ts src/gateway/openresponses-parity.test.ts(21 passed)git diff --check无需QA测试